Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks how moving bleed is handled and adds support for Aggravated bleeding
If the enemy is moving it functions the same as before, (but better breakdowns, and fixes to the specter which it didnt work on)
If the bleeding is always aggravated (Gladiator, or party aggravate) then it applies the full effect
If however its not always aggravated, then it applies with a bleed stack potential of the number of hits it takes to aggravate on average less, eg if you have 100% chance to aggravate, then the stack potential is 1 less, if you have a 25% chance to, then its 4 less, and if you have a 10% chance to then its a stack potential of 10 less, this means getting more aggravate chance increases dps correctly, and gladiator or enemy moving is slightly stronger than 100% chance
3 issues remaining with this PR
Bleed stack potential override config isnt used directly for aggravated bleeds, and theres no way to set them incase something is wrong
Other hits dont aggravate bleeding, this is particularly notable for not being able to aggravate minions bleed damage with your attacks
The code is pretty messy, and might need to be redone
edit: it also doesnt handle the mastery to aggravate bleeds older than 4 seconds, Ill look into fixing that soon